Add profile details #123388
Add profile details #123388
Conversation
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| StringBuilder sb = new StringBuilder(); | ||
| sb.append(this.getClass().getSimpleName()).append("["); | ||
| sb.append("maxPageSize = ").append(maxPageSize); | ||
| sb.append("shards = ").append(sortedUnion(processedShards, sliceQueue.remainingShards())); |
There was a problem hiding this comment.
I wonder if it is also worth including it in the status object as well?
There was a problem hiding this comment.
What about having it in the status only, instead of the toString? I imagine toString is a bit like an identity. So the decision would be whether we view this is part of the identify?
There was a problem hiding this comment.
I believe it should be. Each LuceneOperator is only used with list of shards it is originally initialized with
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
LGTM. Had some minor comments, but nothing important.
|
|
||
| public Iterable<LuceneSlice> getSlices() { | ||
| return slices; | ||
| public Collection<String> remainingShards() { |
There was a problem hiding this comment.
Should we name this method remainingShardIds, since it returns strings, not shards?
There was a problem hiding this comment.
I think that might be confused with org.elasticsearch.index.shard.ShardId. Probably this should be remainingShardIdentifiers() as it relies on shardContext().shardIdentifier()
3 participants
This adds list of target shards to operator description.